Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disttask: change the test package to "*_test" #42264

Merged
merged 3 commits into from
Mar 17, 2023
Merged

disttask: change the test package to "*_test" #42264

merged 3 commits into from
Mar 17, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 15, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42262

Problem Summary:

What is changed and how it works?

  • Change the test package to "*_test"
  • Tiny update
  • Make TestSimple stable, add a round operation for time.
 dispatcher_test.go:150: 
        	Error Trace:	disttask/framework/dispatcher/dispatcher_test.go:150
        	            				disttask/framework/dispatcher/dispatcher_test.go:178
        	Error:      	Not equal: 
        	            	expected: "2023-03-15 03:01:18"
        	            	actual  : "2023-03-15 03:01:19"

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2023
@zimulala zimulala force-pushed the zimuxia/dispatcher-concurrent branch from b639e26 to ffc1984 Compare March 15, 2023 10:32
@pingcap pingcap deleted a comment from ti-chi-bot Mar 15, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2023
GMHDBJD
GMHDBJD approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2023
@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ffc1984

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2023
@hawkingrei
Copy link
Member

/retest

@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

Failed because DATA RACE: #42270

@zimulala
Copy link
Contributor Author

/test mysql-test

@ti-chi-bot
Copy link
Member

@zimulala: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala zimulala mentioned this pull request Mar 16, 2023
Closed
@zimulala
Copy link
Contributor Author

Failed because DATA RACE: #42307

@zimulala
Copy link
Contributor Author

/test mysql-test

3 similar comments
@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

/test mysql-test

@lance6716 lance6716 mentioned this pull request Mar 16, 2023
Merged
12 tasks
@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

/test mysql-test

5 similar comments
@hawkingrei
Copy link
Member

/test mysql-test

@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

/test mysql-test

@zimulala
Copy link
Contributor Author

/test mysql-test

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@zimulala
Copy link
Contributor Author

/test mysql-test

This was referenced Mar 17, 2023
Closed
Closed
@zimulala
Copy link
Contributor Author

/test mysql-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2023
@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b6c8be5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2023
@ti-chi-bot ti-chi-bot merged commit ad30aaf into pingcap:master Mar 17, 2023
@zimulala zimulala deleted the zimuxia/dispatcher-concurrent branch March 17, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the test package to *_test
5 participants
@zimulala @ti-chi-bot @hawkingrei @lcwangchao @GMHDBJD