Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spool: fix unstable test TestPoolTuneScaleUpAndDown #42187

Merged
merged 1 commit into from
Mar 14, 2023
Merged

spool: fix unstable test TestPoolTuneScaleUpAndDown #42187

merged 1 commit into from
Mar 14, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42163

Problem Summary:

Some tasks are still increasing after Tune, so we need to wait for all tasks to be completed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2023
hawkingrei
hawkingrei commented Mar 14, 2023
View reviewed changes
resourcemanager/pool/spool/spool_test.go
@@ -96,7 +96,7 @@ func TestPoolTuneScaleUpAndDown(t *testing.T) {
}()
}
p.Tune(8)
time.Sleep(500 * time.Millisecond)
wg.Wait()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will wait for the task complete.

@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@ti-chi-bot
Copy link
Member

@iosmanthus: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

GMHDBJD
GMHDBJD approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 766a299

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@ti-chi-bot ti-chi-bot merged commit 56e3c34 into pingcap:master Mar 14, 2023
@hawkingrei hawkingrei deleted the fix_TestPoolTuneScaleUpAndDown branch March 14, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@iosmanthus iosmanthus iosmanthus approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable test TestPoolTuneScaleUpAndDown
5 participants
@hawkingrei @ti-chi-bot @lance6716 @iosmanthus @GMHDBJD