Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Update roadmap.md #42139

Merged
merged 2 commits into from
Mar 14, 2023
Merged

*: Update roadmap.md #42139

merged 2 commits into from
Mar 14, 2023

Conversation

yiwen92
Copy link
Contributor

@yiwen92 yiwen92 commented Mar 13, 2023 •
edited
Loading

minor change on security feature

What problem does this PR solve?

Issue Number: close #42178

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@yiwen92
Update roadmap.md
7bb5aea 
minor change on security
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2023
@yiwen92
Copy link
Contributor Author

yiwen92 commented Mar 13, 2023

@ran-huang PTAL

ran-huang
ran-huang approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

roadmap.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@ran-huang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yiwen92 yiwen92 changed the title Update roadmap.md *: Update roadmap.md Mar 13, 2023
@yiwen92
Copy link
Contributor Author

yiwen92 commented Mar 13, 2023

/assign @IANTHEREAL @dveeden Could you pls help to merge.

@yiwen92
Copy link
Contributor Author

yiwen92 commented Mar 14, 2023

pls help to merge @bb7133 thx！

bb7133
bb7133 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
@bb7133
Copy link
Member

bb7133 commented Mar 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: addade9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit a36d1e2 into pingcap:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@dveeden dveeden dveeden approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update TiDB roadmap
6 participants
@yiwen92 @ti-chi-bot @bb7133 @hawkingrei @dveeden @ran-huang