Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix integration test #41961

Merged
merged 1 commit into from
Mar 7, 2023
Merged

lightning: fix integration test #41961

merged 1 commit into from
Mar 7, 2023

Conversation

dsdashun
Copy link
Contributor

@dsdashun dsdashun commented Mar 6, 2023

What problem does this PR solve?

Issue Number: close #41960

Problem Summary:

What is changed and how it works?

Fixed the integration test failure introduced by #40793

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • maxshuang
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
@dsdashun
Copy link
Contributor Author

dsdashun commented Mar 6, 2023

/run-integration-br-test

1 similar comment
@dsdashun
Copy link
Contributor Author

dsdashun commented Mar 7, 2023

/run-integration-br-test

@dsdashun
Copy link
Contributor Author

dsdashun commented Mar 7, 2023

/run-build

@purelind
Copy link
Contributor

purelind commented Mar 7, 2023

/retest

@dsdashun
Copy link
Contributor Author

dsdashun commented Mar 7, 2023

/run-integration-br-test

1 similar comment
@dsdashun
Copy link
Contributor Author

dsdashun commented Mar 7, 2023

/run-integration-br-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 7, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2023
niubell
niubell approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@niubell niubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2023
@dsdashun
Copy link
Contributor Author

dsdashun commented Mar 7, 2023

Integration test passed: https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/15425/pipeline/124/

@dsdashun
Copy link
Contributor Author

dsdashun commented Mar 7, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d3cfc6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2023
@ti-chi-bot ti-chi-bot merged commit dd31639 into pingcap:release-6.5 Mar 7, 2023
@dsdashun dsdashun deleted the fix-41960 branch March 7, 2023 02:06
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxshuang maxshuang maxshuang approved these changes

@niubell niubell niubell approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dsdashun @ti-chi-bot @purelind @niubell @maxshuang @VelocityLight