Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: rename and move some struct #41946

Merged
merged 5 commits into from
Mar 6, 2023
Merged

lightning: rename and move some struct #41946

merged 5 commits into from
Mar 6, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Mar 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #40499

Problem Summary:

What is changed and how it works?

  • rename some struct to better reflect what it does, such as tableRestore to tableImporter
  • move chunk related code into separate file

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 6, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/run-integration-br-test

D3Hunter
D3Hunter commented Mar 6, 2023
View reviewed changes
br/pkg/lightning/importer/chunk_process.go
// chunkProcessor process data chunk
// for local backend it encodes and writes KV to local disk
// for tidb backend it transforms data into sql and executes them.
type chunkProcessor struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from previous restore.go

br/pkg/lightning/importer/chunk_process_test.go
@@ -780,3 +780,32 @@ func TestCompressChunkRestore(t *testing.T) {
err = cr.parser.ReadRow()
require.Equal(t, io.EOF, errors.Cause(err))
}

func TestGetColumnsNames(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from previous restore_table_test.go

br/pkg/lightning/importer/table_import.go
@@ -89,12 +91,121 @@ func NewTableRestore(
}, nil
}

func (tr *TableRestore) Close() {
func (tr *TableImporter) importTable(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from previous restore.go

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 6, 2023
@D3Hunter D3Hunter requested a review from lance6716 March 6, 2023 05:18
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/test build

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/run-integration-br-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45f828b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

lightning ci pass
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/15404/pipeline/114/

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/merge

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/test build

@ti-chi-bot
Copy link
Member

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 6, 2023

/test build

@ti-chi-bot ti-chi-bot merged commit 9958a93 into master Mar 6, 2023
@ti-chi-bot ti-chi-bot deleted the refactor branch March 6, 2023 09:49
@okJiang okJiang mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D3Hunter @ti-chi-bot @hawkingrei @lance6716