Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/lightning: change KvPair's row ID type from int64 to []bytes #41787

Merged
merged 14 commits into from
Mar 1, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Feb 28, 2023

What problem does this PR solve?

Issue Number: ref #37119

Problem Summary:

In distributed execution framework, adding index job is split into multiple sub-tasks. Different TiDB instance may pick different sub-tasks up and execute them. Some of the sub-tasks may be rescheduled to another TiDB instance if the previous one halted due to some reasons.

In the perspective of the TiDB instance, it must be able to solve the reentrancy problem for the same range. Otherwise, an unexpected "duplicate key" error is reported even if there is no duplicate row actually.

To detect the duplicate key, lightning provides a field RowID(int64) to identify the row in the data source, appends it to the key slice and stores the key slice to the local engine. Before importing the data to TiKV, the iterator reads the keys, strips their row IDs, and compares the keys to decide whether they are duplicate.

Thus, it is the caller responsibility to guarantee that the same index key has the same RowID. For lightning, it is natural to use the "file offset" as the RowID. However, int64 is not enough to identify a row for adding index.

What is changed and how it works?

This PR changes the RowID type to []byte so that the handles(including int handles and common handles) can be used as the RowID.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2023
@tangenta tangenta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@tangenta tangenta changed the title br/lightning: change KvPair's row ID type from int64 to []bytes br/lightning: change KvPair's row ID type from int64 to []bytes Feb 28, 2023
@ti-chi-bot ti-chi-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Feb 28, 2023
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/lightning/backend/local/key_adapter.go Show resolved Hide resolved
br/pkg/lightning/backend/kv/sql2kv.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 1, 2023
@tangenta
Copy link
Contributor Author

tangenta commented Mar 1, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9101b3a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2023
@ti-chi-bot ti-chi-bot merged commit 17c1376 into pingcap:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants