Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix revoke USAGE #41774

Merged
merged 2 commits into from
Feb 28, 2023
Merged

executor: fix revoke USAGE #41774

merged 2 commits into from
Feb 28, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Feb 28, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #41773

Problem Summary: Should skip USAGE, which is 0. It does not have coressponding column on priv table.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix error on 'REVOKE USAGE ...'

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2023
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 28, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 28, 2023
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5939a03

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@xhebox
fix test
a6eadf1 
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@xhebox
Copy link
Contributor Author

xhebox commented Feb 28, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a6eadf1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@ti-chi-bot ti-chi-bot merged commit 6c1674c into pingcap:master Feb 28, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 28, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #41779.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 28, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #41780.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 28, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41781.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 28, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #41782.

ti-chi-bot added a commit that referenced this pull request Feb 28, 2023
@ti-chi-bot
executor: fix revoke USAGE (#41774) (#41781)
90a66e6 
close #41773
ti-chi-bot added a commit that referenced this pull request Feb 28, 2023
@ti-chi-bot
executor: fix revoke USAGE (#41774) (#41780)
3246a21 
close #41773
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
executor: fix revoke USAGE (#41774) (#41779)
34351b5 
close #41773
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
executor: fix revoke USAGE (#41774) (#41782)
cd7e122 
close #41773
@xhebox xhebox deleted the 41773 branch April 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incompatibible behavior between mysql and tidb with revoke
4 participants
@xhebox @ti-chi-bot @xiongjiwei @CbcWestwolf