Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add 2pb logic and fix resolve index bug for partitionTopN #41763

Closed
wants to merge 10 commits into from
Closed

planner: add 2pb logic and fix resolve index bug for partitionTopN #41763

wants to merge 10 commits into from

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Feb 27, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #39792

Problem Summary: partitionTopN lack of 2pb logic and have a bug about resolve index.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2023
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2023
@LittleFall
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2023
@LittleFall LittleFall changed the title planner: add 2pb for partitionTopN | tidb-test=pr/2091 planner: add 2pb and fix resolve index bug for partitionTopN | tidb-test=pr/2091 Mar 13, 2023
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2023
@LittleFall LittleFall changed the title planner: add 2pb and fix resolve index bug for partitionTopN | tidb-test=pr/2091 planner: add 2pb logic and fix resolve index bug for partitionTopN | tidb-test=pr/2091 Mar 13, 2023
@LittleFall
Copy link
Contributor Author

/rebuild

@LittleFall
Copy link
Contributor Author

/build

@LittleFall
Copy link
Contributor Author

/retest-required

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2023
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 16, 2023
@AilinKid
Copy link
Contributor

/retest

@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 92c8ff2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2023
@windtalker
Copy link
Contributor

/merge

@windtalker
Copy link
Contributor

/test unit-test

@windtalker
Copy link
Contributor

/merge

@windtalker
Copy link
Contributor

/test mysql-test

@windtalker windtalker changed the title planner: add 2pb logic and fix resolve index bug for partitionTopN | tidb-test=pr/2091 planner: add 2pb logic and fix resolve index bug for partitionTopN Mar 16, 2023
@windtalker
Copy link
Contributor

/test mysql-test

@windtalker
Copy link
Contributor

/test unit-test

@hawkingrei
Copy link
Member

/retest

@windtalker
Copy link
Contributor

/test unit-test

@windtalker
Copy link
Contributor

/test mysql-test

2 similar comments
@windtalker
Copy link
Contributor

/test mysql-test

@windtalker
Copy link
Contributor

/test mysql-test

@windtalker windtalker mentioned this pull request Mar 16, 2023
Merged
12 tasks
@windtalker
Copy link
Contributor

/test mysql-test

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot
Copy link
Member

@LittleFall: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 4367fb5 link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@windtalker
Copy link
Contributor

close as #42334 include all the fix in this pr

@windtalker windtalker closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi left review comments

@AilinKid AilinKid AilinKid approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LittleFall @ti-chi-bot @AilinKid @windtalker @hawkingrei @winoros @gengliqi