Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: improve bazel config #41430

Merged
merged 3 commits into from
Feb 15, 2023
Merged

*: improve bazel config #41430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33a8c9a
*: improve store bazel config
hawkingrei Feb 15, 2023
acd7cf7
*: improve br to make test faster
hawkingrei Feb 15, 2023
ba31e07
*: improve br to make test faster
hawkingrei Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions store/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ go_test(
],
embed = [":store"],
flaky = True,
shard_count = 23,
Copy link
Contributor

@Defined2014 Defined2014 Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add a new test in store, should we increase the shard_count here? Maybe use a constant value is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, you don't need to worry about this. Unless you write a flaky test here, we will increase it when this package's test is slow.

deps = [
"//domain",
"//kv",
Expand Down