Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: improve makefile #41399

Merged
merged 1 commit into from
Feb 14, 2023
Merged

*: improve makefile #41399

merged 1 commit into from
Feb 14, 2023

Conversation

hawkingrei
Copy link
Member

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
*: improve makefile
9352a8b 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2023
hawkingrei
hawkingrei commented Feb 14, 2023
View reviewed changes
Makefile
@@ -31,7 +31,7 @@ dev: checklist check explaintest gogenerate br_unit_test test_part_parser_dev ut
# Install the check tools.
check-setup:tools/bin/revive

check: parser_yacc check-parallel lint tidy testSuite errdoc license check-bazel-prepare
check: check-bazel-prepare parser_yacc check-parallel lint tidy testSuite errdoc license
Copy link
Member Author

@hawkingrei hawkingrei Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a more common problem that developers forget to run make bazel_prepare.

hawkingrei
hawkingrei commented Feb 14, 2023
View reviewed changes
Makefile
@@ -409,7 +409,7 @@ bazel_test: failpoint-enable bazel_ci_prepare
-//tests/globalkilltest/... -//tests/readonlytest/... -//br/pkg/task:task_test


bazel_coverage_test: failpoint-enable bazel_ci_prepare
bazel_coverage_test: check-bazel-prepare failpoint-enable bazel_ci_prepare
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If forget to make bazel_prepare. Please stop to run ut.

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 14, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9352a8b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit 0b6ccdc into pingcap:master Feb 14, 2023
@hawkingrei hawkingrei deleted the improve_makefile_20220214 branch February 14, 2023 10:27
blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @blacktear23
*: improve makefile (pingcap#41399)
4c7de4c
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @ghazalfamilyusa
*: improve makefile (pingcap#41399)
c5fe1eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @ti-chi-bot @lance6716 @zimulala