Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: set switch default to false (#41336) #41384

Merged
merged 1 commit into from
Feb 14, 2023
Merged

telemetry: set switch default to false (#41336) #41384

merged 1 commit into from
Feb 14, 2023

Conversation

AstroProfundis
Copy link
Contributor

close #41335

What problem does this PR solve?

cherry-pick #41336

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@AstroProfundis AstroProfundis requested a review from a team as a code owner February 14, 2023 07:36
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • fzzf678

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2023
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 14, 2023
@AstroProfundis
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@wshwsh12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 414fdfb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit beddc60 into pingcap:release-6.6 Feb 14, 2023
@AstroProfundis AstroProfundis deleted the cp-41336 branch February 14, 2023 09:35
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Feb 15, 2023
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Feb 28, 2023
@AstroProfundis @iosmanthus
telemetry: set switch default to false (pingcap#41336) (pingcap#41384)
0f6e1a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzzf678 fzzf678 fzzf678 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AstroProfundis @ti-chi-bot @wshwsh12 @winoros @XuHuaiyu @fzzf678 @VelocityLight @sre-bot