Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix cleanup subtasks after cancel add index with dist-reorg #41372

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Feb 14, 2023

What problem does this PR solve?

Issue Number: close #41371

Problem Summary:

What is changed and how it works?

Do cleanupBackfillJobs after canceling the operation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 14, 2023
@zimulala zimulala requested review from Defined2014 and hawkingrei and removed request for Defined2014 February 14, 2023 04:30
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2023
@zimulala zimulala requested a review from Defined2014 February 14, 2023 04:31
@hawkingrei
Copy link
Member

@zimulala I found it in the CI.

panic: runtime error: invalid memory address or nil pointer dereference

[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x448b259]


goroutine 183764 [running]:

github.com/pingcap/tidb/ddl.(*reorgCtx).isReorgCanceled(...)

	ddl/reorg.go:113

github.com/pingcap/tidb/ddl.(*reorgCtx).IsReorgCanceled(...)

	ddl/ddl_test.go:62

github.com/pingcap/tidb/ddl_test.TestUsingReorgCtx.func2()

	ddl/ddl_worker_test.go:334 +0xd9

github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()

	util/wait_group_wrapper.go:154 +0x6b

created by github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run

	util/wait_group_wrapper.go:152 +0x8d

--

Coverage runner: Not collecting coverage for failed test.


@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@zimulala
Copy link
Contributor Author

zimulala commented Feb 14, 2023

@zimulala I found it in the CI.

panic: runtime error: invalid memory address or nil pointer dereference

[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x448b259] ...

@hawkingrei
This may be an unstable test or a bug, but it doesn't because of this PR. I will handle it. Could you add an issue?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3b103e0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@hawkingrei hawkingrei removed the request for review from a team February 15, 2023 02:41
@ti-chi-bot ti-chi-bot merged commit 7ca36a6 into pingcap:master Feb 15, 2023
@zimulala zimulala deleted the zimuxia/dist-reorg-cleanup branch February 15, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It mayn't cleanup subtasks after cancel add index with dist-reorg
4 participants