Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update bazel #41369

Merged
merged 8 commits into from
Feb 14, 2023
Merged

*: update bazel #41369

merged 8 commits into from
Feb 14, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 14, 2023 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #41377

Problem Summary:

What is changed and how it works?

  1. update some bazel config. set timeout as short and increase the shard_count
  2. split some test cases into new folders. it can add concurrency for the test cases.
    because bezel's max concurrency is 50 in a folder.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 14, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2023
@hawkingrei
*: update bazel
aadb456 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update bazel
dfb38de 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update bazel
6792ee7 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update bazel
5b6c929 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the try_to_upate_bazel_config branch from 4acffd6 to 5b6c929 Compare February 14, 2023 05:24
@hawkingrei
*: update bazel
fd76460 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update bazel
b526bca 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update bazel
2fc7b9a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update bazel
a246115 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@hawkingrei hawkingrei requested a review from bb7133 February 14, 2023 06:18
@hawkingrei hawkingrei removed the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 14, 2023
@hawkingrei hawkingrei requested a review from xhebox February 14, 2023 06:25
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@xhebox
Copy link
Contributor

xhebox commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a246115

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit 84871df into pingcap:master Feb 14, 2023
blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @blacktear23
*: update bazel (pingcap#41369)
2ad7c72 
ref pingcap#41377
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @ghazalfamilyusa
*: update bazel (pingcap#41369)
aa28289 
ref pingcap#41377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@lance6716 lance6716 lance6716 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@Defined2014 Defined2014 Awaiting requested review from Defined2014

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @ti-chi-bot @xhebox @lance6716