-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain, tidb-server: stop launching new auto analyze job when shutting down #41346
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 87b8330
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
…shutting down (pingcap#476) * test for small ttl of etcd key Signed-off-by: zeminzhou <[email protected]> * domain, tidb-server: stop launching new auto analyze job when shutting down (pingcap#41346) close pingcap#41318 * clean other change Signed-off-by: zeminzhou <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Co-authored-by: Yifan Xu <[email protected]>
What problem does this PR solve?
Issue Number: close #41318
Problem Summary:
What is changed and how it works?
When shutting down, stop
autoAnalyzeWorker
from launching new auto analyze job.Check List
Tests
Assume auto analyze of
t1
is triggered. Then Ctrl+C to shut down the tidb server. Auto analyze oft1
is killed. Before the PR, auto analyze oft2
may be triggered(I addtime.Sleep
incleanup
to make that reproducible). After the PR, auto analyze oft2
would not be triggered.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.