Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade golangci-linter #41317

Merged
merged 8 commits into from
Feb 14, 2023
Merged

*: upgrade golangci-linter #41317

merged 8 commits into from
Feb 14, 2023

Conversation

hawkingrei
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
*: update bazel
28955a8 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update bazel
37ebc92 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update golangci-linter
82016b1 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2023
@hawkingrei hawkingrei changed the title upgrade golangci-linter *: upgrade golangci-linter Feb 12, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 12, 2023
@hawkingrei
*: update golangci-linter
4569b24 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update golangci-linter
c61f1a3 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update golangci-linter
9420488 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update golangci-linter
d6a1152 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: update golangci-linter
cfe476b 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from xhebox February 13, 2023 06:48
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cfe476b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot merged commit a78ff88 into pingcap:master Feb 14, 2023
blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @blacktear23
*: upgrade golangci-linter (pingcap#41317)
71f2058
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @ghazalfamilyusa
*: upgrade golangci-linter (pingcap#41317)
ad3c1b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@lance6716 lance6716 lance6716 approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @ti-chi-bot @lance6716 @xiongjiwei