-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDL: Skip collecting TiFlash status when TiFlash is down (#40872) #40888
DDL: Skip collecting TiFlash status when TiFlash is down (#40872) #40888
Conversation
Signed-off-by: hehechen <[email protected]>
Signed-off-by: hehechen <[email protected]>
Signed-off-by: hehechen <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-unit-test |
/test unit-test |
@windtalker: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #40888 +/- ##
================================================
Coverage ? 77.0633%
================================================
Files ? 1083
Lines ? 374575
Branches ? 0
================================================
Hits ? 288660
Misses ? 70119
Partials ? 15796 |
This is an automated cherry-pick of #40872
What problem does this PR solve?
Issue Number: close #38484
Problem Summary:
What is changed and how it works?
Skip
CollectTiFlashStatus
when the state of TiFlash store isDown
.Check List
Tests
Two TFlash nodes, keep a TiFlash down and then set tiflash replica. Expect that the
available
become 1.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.