-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizer: add test cases for predicate simplifications #40775
Optimizer: add test cases for predicate simplifications #40775
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ee43901
to
7e3cacb
Compare
Please sign the CLA and remove the unintentional change, other than that, looks good to me! |
7e3cacb
to
844170f
Compare
Removed the unintentional change. For CLA, I signed it yesterday and still showing it is pending. To make sure, I added my ping cap email [email protected] to my github account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
LGTM. We may need help from IT about the CLA.
Hi,
I have done that many time so far. I get that I already signed it and somehow it is not clearing in the PR.
See image of what I keep getting showing that I already accepted.
… On Jan 26, 2023, at 8:36 PM, Weizhen Wang ***@***.***> wrote:
@ghazalfamilyusa <https://github.com/ghazalfamilyusa> Please sign the CLA.
—
Reply to this email directly, view it on GitHub <#40775 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3EVQBJQQZAOXIH2HMBHPS3WUNGFNANCNFSM6AAAAAAUG2EF2Y>.
You are receiving this because you were mentioned.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 127ad80c2739ec9fab649907cdeda8310b3d492b
|
@ghazalfamilyusa: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/hold Please resolve the CLA problem. |
0fc3ee5
to
7046410
Compare
Merge canceled because a new commit is pushed. |
…hange Operator; (pingcap#40132) ref pingcap/tiflash#6620, close pingcap#40494
… contains all regions (pingcap#40504) close pingcap#40391, ref pingcap#41005
…ccess conditions on MVIndex (pingcap#41013) ref pingcap#40191
b0fb538
to
b01d576
Compare
Process got complicated when a different email is used for the commit. Will do another clean PR. |
Issue Number: ref #40221
Problem Summary:
This PR just adds tests of various predicate simplification optimizations cases. The purpose of the test is to
(1) document existing cases. This include (a) removing redundancy for identical simple predicates
like =, <>, > and <, >= and <=, (b) un-satisfiable conditions like x=1 and x <> 1 (c) intersection of two in lists.
(2) list cases not working currently and should be addressed in future optimizations. These cases cover
the use case in #40221) and more like intersection of two "not in" lists.
(3) establish a place holder for predicate simplification is a general optimizer rewrite rule and sub-rules.
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.