Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: remove useless code #40756

Merged
merged 5 commits into from
Jan 29, 2023
Merged

ddl: remove useless code #40756

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5be6275
ddl: remove useless code
zimulala Jan 20, 2023
981c963
Merge branch 'master' into zimuxia/init-testv
hawkingrei Jan 21, 2023
d3f549e
Merge branch 'master' into zimuxia/init-testv
ti-chi-bot Jan 29, 2023
83da113
Merge branch 'master' into zimuxia/init-testv
ti-chi-bot Jan 29, 2023
3d7176c
Merge branch 'master' into zimuxia/init-testv
ti-chi-bot Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ddl/ddl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ package ddl
import (
"context"
"encoding/json"
"flag"
"fmt"
"runtime"
"strconv"
Expand Down Expand Up @@ -1249,12 +1248,6 @@ var (
RunInGoTest bool
)

func init() {
if flag.Lookup("test.v") != nil || flag.Lookup("check.v") != nil {
RunInGoTest = true
Copy link
Member

@hawkingrei hawkingrei Jan 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

we have many of the same codes. I think we can unite it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that because of the init function. In addition, we set ddl.RunInGoTest.
For example, here you list sanity_check.go line185 with no variables.

}
}

// GetDropOrTruncateTableInfoFromJobsByStore implements GetDropOrTruncateTableInfoFromJobs
func GetDropOrTruncateTableInfoFromJobsByStore(jobs []*model.Job, gcSafePoint uint64, getTable func(uint64, int64, int64) (*model.TableInfo, error), fn func(*model.Job, *model.TableInfo) (bool, error)) (bool, error) {
for _, job := range jobs {
Expand Down