-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: fix change status sql argument (#40234) #40241
ttl: fix change status sql argument (#40234) #40241
Conversation
Signed-off-by: YangKeao <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold high priority for trunk branch |
/unhold |
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #40241 +/- ##
================================================
Coverage ? 73.6685%
================================================
Files ? 1080
Lines ? 346658
Branches ? 0
================================================
Hits ? 255378
Misses ? 74858
Partials ? 16422 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #40234
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #40231
The TTL always fails to update job status. It's actually not a big problem as ttl didn't depend on the status to schedule.
This problem is caused by a custom-defined type argument (even if the underlying type is a string) cannot be handled by the
escapeSQL
. The funny thing is that the initial 'waiting' is inlined in the SQL, so the job status could be 'waiting' 😃 .What is changed and how it works?
Convert the argument to string
Check List
Tests
Release note