*: fix revive false positive with generics

[hawkingrei]

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

it is found by https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_check/detail/ghpr_check/6720/pipeline.

the revive which run by cli is old. so that we disable it to fix. It has been enabled in the bazel nogo.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Defined2014
• YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[YangKeao]

LGTM

[YangKeao]

For a detailed description of the problem:

func (b *Bucket[T]) Next() *Bucket[T] {
	return b.next
}

func (w *Window[T]) ResetWindow() {
	for offset := range w.buckets {
		w.ResetBucket(offset)
	}
}

IIUC, revive failed to parse these two different types, so it thinks they are the same type (unknown, or invalid) and should have the same receiver b.

[hawkingrei]

Right. We should eliminate the revive by cli in the CI as soon as possible.

[hawkingrei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 42500b0

[sre-bot]

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-1	🟥 failed 1, success 25, total 26	4 min 2 sec	New failing
idc-jenkins-ci/integration-cdc-test	🔴 failed 1, success 39, total 40	27 min	Existing failure
idc-jenkins-ci-tidb/common-test	🟢 all 11 tests passed	19 min	Existing passed
idc-jenkins-ci-tidb/integration-common-test	🟢 all 17 tests passed	19 min	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	6 min 35 sec	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	6 min 23 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	5 min 45 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	3 min 43 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	2 min 44 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed