Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add resource manage to schedule pool by static #39647

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 6, 2022

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #39657

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 6, 2022
@hawkingrei hawkingrei mentioned this pull request Dec 6, 2022
12 tasks
build/nogo_config.json Outdated Show resolved Hide resolved
resourcemanager/rm.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-check-dev

@hawkingrei
Copy link
Member Author

/run-unit-test

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 12, 2022
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/run-check_dev

@hawkingrei hawkingrei closed this Dec 13, 2022
@hawkingrei hawkingrei reopened this Dec 13, 2022
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
Copy link
Member Author

/run-check_dev

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2022
@ti-chi-bot
Copy link
Member

@hawkingrei: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #39647 (1faed29) into master (2ea253e) will decrease coverage by 0.0176%.
Report is 3672 commits behind head on master.
The diff coverage is 67.4418%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #39647        +/-   ##
================================================
- Coverage   73.3395%   73.3219%   -0.0177%     
================================================
  Files          1076       1079         +3     
  Lines        341769     343965      +2196     
================================================
+ Hits         250652     252202      +1550     
- Misses        74955      75439       +484     
- Partials      16162      16324       +162     

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Dec 19, 2023
Copy link

tiprow bot commented Feb 27, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 1faed29 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Nov 18, 2024

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 1faed29 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 1faed29 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test 1faed29 link true /test mysql-test
idc-jenkins-ci-tidb/build 1faed29 link true /test build
pull-mysql-client-test 1faed29 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/unit-test 1faed29 link true /test unit-test
pull-integration-ddl-test 1faed29 link true /test pull-integration-ddl-test
pull-br-integration-test 1faed29 link true /test pull-br-integration-test
pull-lightning-integration-test 1faed29 link true /test pull-lightning-integration-test
pull-integration-e2e-test 1faed29 link true /test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add resource manage to schedule pool by static
3 participants