Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix goleak in the statisticstest #39503

Merged
merged 5 commits into from
Nov 30, 2022
Merged

*: fix goleak in the statisticstest #39503

merged 5 commits into from
Nov 30, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 30, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #39502

Problem Summary:

What is changed and how it works?

In fact, the old limit is useless. they are defined in the RunTestMain.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Nov 30, 2022
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@hawkingrei hawkingrei changed the title *: data race in the statisticstest *: fix goleak in the statisticstest Nov 30, 2022
@hawkingrei hawkingrei force-pushed the fix_goleak_statisticstest branch from a2ec9c4 to 1ee635c Compare November 30, 2022 11:18
@hawkingrei hawkingrei requested a review from lance6716 November 30, 2022 11:20
@CbcWestwolf
Copy link
Member

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ee635c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@hawkingrei hawkingrei force-pushed the fix_goleak_statisticstest branch from 5cc9c08 to 1ee635c Compare November 30, 2022 12:59
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot merged commit fa7cf31 into pingcap:master Nov 30, 2022
@hawkingrei hawkingrei deleted the fix_goleak_statisticstest branch November 30, 2022 16:27
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [3] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 16, success 1, total 17 6 min 32 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 6, success 0, total 6 4 min 36 sec New failing
idc-jenkins-ci-tidb/integration-compatibility-test 🟥 failed 1, success 0, total 1 3 min 15 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 39, success 1, total 40 1 hr 11 min Existing failure
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 58 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 45 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 24 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 45 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@hawkingrei hawkingrei mentioned this pull request Nov 30, 2022
Closed
hawkingrei added a commit that referenced this pull request Nov 30, 2022
@hawkingrei
Revert "*: fix goleak in the statisticstest (#39503)"
e4daa8d 
This reverts commit fa7cf31.
@hawkingrei hawkingrei mentioned this pull request Nov 30, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

goleak in the statisticstest
5 participants
@hawkingrei @ti-chi-bot @CbcWestwolf @sre-bot @lance6716