Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: refractor ttl pkg into multiple sub packages #39491

Merged
merged 9 commits into from
Dec 1, 2022
Merged

ttl: refractor ttl pkg into multiple sub packages #39491

merged 9 commits into from
Dec 1, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao [email protected]

What problem does this PR solve?

Issue Number: close #39490

Problem Summary:

Split the util functions inside ttl into multiple standalone packages.

What is changed and how it works?

Just move the files, and change some headers. Nothing new.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@YangKeao YangKeao added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 30, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 30, 2022
@YangKeao YangKeao requested a review from lcwangchao November 30, 2022 07:39
@YangKeao
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@YangKeao
Copy link
Member Author

/run-check_dev_2

@YangKeao
Copy link
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 37faaca90b38cd78dbad61655a4b9df799d43b33

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@hawkingrei
Copy link
Member

/unhold
/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b1c9d6644f3170bce63b6627273051a43f84e06f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@YangKeao
Copy link
Member Author

@hawkingrei Could you help me to merge it again? I run the make bazel_prepare and pushed a commit to reorder the position flaky = True (keep consistent with the generated position).

@YangKeao
Copy link
Member Author

/merge

2 similar comments
@lcwangchao
Copy link
Collaborator

/merge

@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

/run-all-tests

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 091715a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@YangKeao
Copy link
Member Author

/run-check_dev

@YangKeao
Copy link
Member Author

/run-check_dev_2

5 similar comments
@lcwangchao
Copy link
Collaborator

/run-check_dev_2

@lcwangchao
Copy link
Collaborator

/run-check_dev_2

@lcwangchao
Copy link
Collaborator

/run-check_dev_2

@purelind
Copy link
Contributor

purelind commented Dec 1, 2022

/run-check_dev_2

@lcwangchao
Copy link
Collaborator

/run-check_dev_2

@lcwangchao lcwangchao merged commit 7add1c8 into pingcap:master Dec 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 3 min 14 sec New failing
idc-jenkins-ci-tidb/common-test 🟥 all 0 tests passed 2 min 34 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 24 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 4 min 42 sec Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 22 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 5 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@xhebox xhebox xhebox approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refractor ttl package into multiple sub packages
7 participants
@YangKeao @ti-chi-bot @lcwangchao @hawkingrei @purelind @sre-bot @xhebox