-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error: print non-printable chars in hex style for duplicate entry error #39485
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-build |
@tangenta Addressed, PTAL |
expression/integration_test.go
Outdated
@@ -7895,3 +7895,17 @@ func TestIssue39146(t *testing.T) { | |||
tk.MustExec("set @@tidb_enable_vectorized_expression = off;") | |||
tk.MustQuery(`select str_to_date(substr(dest,1,6),'%H%i%s') from sun;`).Check(testkit.Rows("20:23:10")) | |||
} | |||
|
|||
func TestIssue35289(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestIssue35289
is a bad name of test cases. we should avoid it.
I think it is a corner case about insert and we can put it into TestInsert
and comment the issue id.
/run-mysql-test tidb-test=pr/2028 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: aa406ed
|
/run-mysql-test tidb-test=pr/2028 |
1 similar comment
/run-mysql-test tidb-test=pr/2028 |
/run-mysql-test tidb-test=pr/2028 |
/run-mysql-test tidb-test=pr/2028 |
/run-mysql-test tidb-test=pr/2028 |
/merge |
/run-mysql-test tidb-test=pr/2028 |
/merge |
/run-mysql-test |
/run-build |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #35289
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.