-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: improve the log messages and refine code #39456
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 970ab0b
|
/hold |
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5264480
|
/run-mysql-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 66ba28d
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8b809e1
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: aff6a0b
|
TiDB MergeCI notify✅ Well Done! New fixed [4] after this pr merged.
|
What problem does this PR solve?
Problem Summary:
int(variable.GetDDLReorgBatchSize())*copReadBatchFactor
occurs for several times. It could be encapsulated.What is changed and how it works?
As the title said.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.