Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: implement subscription of flush #39445

Merged
merged 49 commits into from
Dec 1, 2022
Merged

log-backup: implement subscription of flush #39445

merged 49 commits into from
Dec 1, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Nov 29, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref tikv/tikv#13824

Problem Summary:
In the post, we were polling the checkpoint of each region from TiKV and calculating the global checkpoint, which isn't so real-timed.

What is changed and how it works?

This PR adapts the new interface which supports subscribing flush events.
Generally, we added a new actor named FlushSubscriber to

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    Tested via:
  • TPCC workload, happy path.
  • TPCC workload, restart cluster every 30 mins.
  • TPCC workload, with one node using older version TiKV (which doesn't support subscribing)
  • TPCC workload, upgrading from older version.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Improve the RPO of PITR.

YuJuncen and others added 28 commits November 2, 2022 11:20
@YuJuncen
use span (tree?) to replace checkpoint heap
77211fe 
Signed-off-by: hillium <[email protected]>
@YuJuncen
adapt ranges
f6b3624 
Signed-off-by: hillium <[email protected]>
@YuJuncen
remove unrelatived code
3db857c 
Signed-off-by: hillium <[email protected]>
@YuJuncen
make CI happy
0b00cc8 
Signed-off-by: hillium <[email protected]>
@YuJuncen
fixed a bug over subranges
b3008d2 
Signed-off-by: hillium <[email protected]>
@YuJuncen
try make linter happy
e592b7e 
Signed-off-by: hillium <[email protected]>
@YuJuncen
Merge branch 'master' into span-tree
bf27ca8
@YuJuncen
updated bazel
a7772ad 
Signed-off-by: hillium <[email protected]>
@YuJuncen
Merge branch 'span-tree' of https://github.com/YuJuncen/tidb into spa…
7613d04 
…n-tree

Signed-off-by: hillium <[email protected]>
@YuJuncen
adapt subscribing
13eee91 
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
@YuJuncen
refactoring subscription
acb5b83 
Signed-off-by: hillium <[email protected]>
@YuJuncen
fix encode
3786634 
Signed-off-by: hillium <[email protected]>
@YuJuncen
make code more clear
0b0a322 
Signed-off-by: hillium <[email protected]>
@YuJuncen
added test for subscriber
0f7a93e 
Signed-off-by: hillium <[email protected]>
@YuJuncen
fix some memory leakage
21198ed 
Signed-off-by: hillium <[email protected]>
@YuJuncen
fixed panic
6578dc3 
Signed-off-by: hillium <[email protected]>
@YuJuncen
fixed MergeAll
f718a02 
Signed-off-by: hillium <[email protected]>
@YuJuncen
fix bugs
585d2e1 
Signed-off-by: hillium <[email protected]>
@YuJuncen
Merge branch 'span-tree' of https://github.com/YuJuncen/tidb into sub…
8764c03 
…scription-flush
@YuJuncen
address comments
fd4918c 
Signed-off-by: hillium <[email protected]>
@YuJuncen
check length before checking
102941e 
Signed-off-by: hillium <[email protected]>
@YuJuncen
Merge branch 'master' into span-tree
7ba6318
@ti-chi-bot
Merge branch 'master' into span-tree
3e619d7
@ti-chi-bot
Merge branch 'master' into span-tree
79cfe5e
@ti-chi-bot
Merge branch 'master' into span-tree
0aec2af
@ti-chi-bot
Merge branch 'master' into span-tree
64c307b
@YuJuncen
Merge branch 'span-tree' of https://github.com/YuJuncen/tidb into sub…
92ccbcb 
…scription-flush

Signed-off-by: hillium <[email protected]>
@YuJuncen
Merge branch 'master' of https://github.com/pingcap/tidb into subscri…
7351c04 
…ption-flush
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 29, 2022
@YuJuncen
address comments
e48f8ec 
Signed-off-by: hillium <[email protected]>
joccau
joccau approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
Leavrth
Leavrth approved these changes Nov 30, 2022
View reviewed changes
br/pkg/streamhelper/flush_subscriber.go Outdated Show resolved Hide resolved
br/pkg/streamhelper/subscription_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Dec 1, 2022

/merge

@joccau
Copy link
Member

joccau commented Dec 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2ad7f64

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Dec 1, 2022

/run-mysql-test

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Dec 1, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 4b1bb5b into pingcap:master Dec 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 24 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 19 min Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 4 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 44 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 54 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 24 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YuJuncen @ti-chi-bot @joccau @sre-bot @Leavrth