-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, domain: handle the corner case that putting the MDL key to etcd failed #39418
ddl, domain: handle the corner case that putting the MDL key to etcd failed #39418
Conversation
Signed-off-by: wjhuang2016 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1b4b372
|
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
Signed-off-by: wjhuang2016 [email protected]
What problem does this PR solve?
Issue Number: close #39416
Problem Summary:
We set jobNeedToSync = false and it assumes that putting the MDL key to etcd won't fail.
What is changed and how it works?
set jobNeedToSync = true if putting the MDL key to etcd failed.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.