Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: optimizate the bazel test #39414

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 28, 2022

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What is changed and how it works?

Why do I put some test cases into a new folder?

because test cases is too much in the executor. bazel allows 50 shards of the test case to run into difference threads. if too many test cases are to run more time in a thread. it will slow down the CI.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wshwsh12
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 28, 2022
@hawkingrei hawkingrei force-pushed the optimization_bazel_test branch from 26dc17f to 1f1aa7b Compare November 28, 2022 08:39
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@hawkingrei hawkingrei requested a review from xhebox November 28, 2022 08:43
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the optimization_bazel_test branch from 8dadc7b to 2d6a850 Compare November 28, 2022 09:17
@hawkingrei
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 28, 2022
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 28, 2022
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2d6a850

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2022
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
Copy link
Member Author

/run-all-tests

5 similar comments
@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 039484a into pingcap:master Nov 28, 2022
@hawkingrei hawkingrei deleted the optimization_bazel_test branch November 28, 2022 11:29
@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 19 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 21 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 31 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 25 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 39 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 40 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants