-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: properly handle existence checks for deleted records in temp index #39371
ddl: properly handle existence checks for deleted records in temp index #39371
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-mysql-test |
/run-build |
Co-authored-by: tangenta <[email protected]>
/run-mysql-test |
…ly check deleteu logic
Co-authored-by: tangenta <[email protected]>
…n2037/tidb into fix-default-on-fast-ddl-ut-part2
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a16e7eb
|
/merge |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #39321
Problem Summary:
When set fast reorg variable on, some ut will failed.
What is changed and how it works?
When user issue
insert on dulplicate update
statement during add index processing.insert on dulplicate update
, it need check unique key exists. when this check processing is in fast_reorg add index period, the check key exists should be done on temp index.This case has some trick place, it test different adding index schema stage to see if key is exist or not. But here still has above problem. In non-public status index, all changes on table that is adding index will reflect to temp idx.
So we have to change key exist also on temp index first.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.