Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix that str_to_date returns different result on no zero date sql mode. (#39316) #39353

Merged
merged 9 commits into from
Nov 26, 2022
Merged

expression: fix that str_to_date returns different result on no zero date sql mode. (#39316) #39353

merged 9 commits into from
Nov 26, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39316

What problem does this PR solve?

Issue Number: close #39146

Problem Summary:

What is changed and how it works?

fix that str_to_date returns different result on no zero date sql mode

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix that str_to_date returns different result on no zero date sql mode.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Nov 24, 2022
@mengxin9014
Copy link
Contributor

/run-all-tests

2 similar comments
@mengxin9014
Copy link
Contributor

/run-all-tests

@mengxin9014
Copy link
Contributor

/run-all-tests

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Nov 24, 2022
@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2024

1 similar comment
@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/2024

@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

3 similar comments
@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/2025

2 similar comments
@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

2 similar comments
@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

@mengxin9014
Copy link
Contributor

/run-mysql-test tidb-test=pr/2025

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2022
@mengxin9014
Copy link
Contributor

/run-all-tests

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 624dba6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2022
@hawkingrei
Copy link
Member

/run-unit-test
/run-check_dev

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mengxin9014
Copy link
Contributor

/run-all-tests

@mengxin9014
fmt
1417a5f 
fmt
@ti-chi-bot ti-chi-bot merged commit 9af95f8 into pingcap:release-6.1 Nov 26, 2022
@mengxin9014 mengxin9014 deleted the cherry-pick-39316-to-release-6.1 branch November 26, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

@mengxin9014 mengxin9014

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @mengxin9014 @hawkingrei @XuHuaiyu @VelocityLight