-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: set memory limit tuner to valid value after trigger tuning #39343
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/merge |
1 similar comment
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1e4ee9b
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #37816
Problem Summary:
Now, memory limit tuner will setMemoryLimit to MaxInt64(No limit) when the first GC is trigger by memory limit. And reset after 1 minute.
In this case, set MemoryLimit to physical memory 88% (80% global memory control default value * 1.1) is better.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.