Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: use alter table remove ttl spec #39341

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao [email protected]

What problem does this PR solve?

Issue Number: close #39340

Problem Summary:

Use alter table remove ttl instead of alter table no_ttl. And remove the support of arbitrary expression, but only support valueExpr from Literal.

What is changed and how it works?

It changed three things:

  1. Change the name of AlterTablePartitionOpt to AlterTableSingleSpecOpt and add a "REMOVE" "TTL" branch to it. We cannot add "REMOVE" "TTL" to other rules or AlterTableSpec because yacc has to know whether to reduce the AlterTableSpec and moving forward to AlterTablePartitionOpt, or try to "REMOVE" "TTL"
  2. Change the value of "TTL" config to valueExpr. Maybe we could modify it to DefaultValueExpr or other wider range grammar later, but supporing number / string literal is enough for today.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Change grammar to remove ttl from `ALTER table NO_TTL` to `ALTER table REMOVE TTL`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 23, 2022
@YangKeao YangKeao force-pushed the change-alter-no-ttl-grammar branch from 108a90a to cd6fe00 Compare November 23, 2022 09:07
@YangKeao YangKeao force-pushed the change-alter-no-ttl-grammar branch from cd6fe00 to 885cfa5 Compare November 23, 2022 11:08
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2022
@YangKeao
Copy link
Member Author

@lcwangchao @hawkingrei Could you help me to merge this PR?

@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9cc5dc0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2022
@ti-chi-bot ti-chi-bot merged commit 84ee284 into pingcap:master Nov 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 24, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-2 🔴 failed 4, success 24, total 28 21 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 4 min 22 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 23 min Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 5 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 43 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use alter table remove ttl rather than alter table no_ttl
5 participants