Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: add system table for TTL status #39315

Merged
merged 2 commits into from
Dec 5, 2022
Merged

ttl: add system table for TTL status #39315

merged 2 commits into from
Dec 5, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 22, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39272

Initialize the system table for TTL.

What is changed and how it works?

This PR does the following things:

  1. Create a status table for TTL as described in RFC. https://github.com/pingcap/tidb/pull/39264/files#diff-3199b62f6b171f846c9c0c1670428817d339e0e2ee2b2a35822df8f532c51e58R97

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Add a system table to record ttl job status.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 22, 2022
@YangKeao YangKeao marked this pull request as draft November 22, 2022 09:47
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2022
@YangKeao YangKeao force-pushed the ttl-add-system-table branch 5 times, most recently from b9fba35 to ee841ef Compare November 22, 2022 12:41
@YangKeao YangKeao marked this pull request as ready for review November 22, 2022 12:41
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2022
@YangKeao YangKeao marked this pull request as draft November 23, 2022 06:13
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@YangKeao YangKeao force-pushed the ttl-add-system-table branch 2 times, most recently from 580d5e2 to a005bed Compare November 24, 2022 02:43
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2022
@YangKeao YangKeao marked this pull request as ready for review November 24, 2022 02:44
@YangKeao YangKeao requested a review from a team as a code owner November 24, 2022 02:44
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
@YangKeao YangKeao force-pushed the ttl-add-system-table branch from a005bed to c8fed7d Compare November 24, 2022 02:45
@YangKeao YangKeao requested a review from hawkingrei November 24, 2022 02:47
@YangKeao YangKeao force-pushed the ttl-add-system-table branch 3 times, most recently from 058825a to a119d5e Compare November 24, 2022 07:48
@YangKeao YangKeao requested a review from lcwangchao November 24, 2022 07:49
@YangKeao YangKeao force-pushed the ttl-add-system-table branch 2 times, most recently from 4aef23b to 32f3d50 Compare November 24, 2022 10:05
@YangKeao YangKeao force-pushed the ttl-add-system-table branch from e0c865c to 9c0799e Compare December 2, 2022 04:14
@YangKeao
Copy link
Member Author

YangKeao commented Dec 2, 2022

/run-unit-test

@YangKeao
Copy link
Member Author

YangKeao commented Dec 2, 2022

@lcwangchao Should we unhold this PR?

@bb7133 PTAL

@YangKeao YangKeao added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Dec 2, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
@YangKeao
add ttl system table
e0fa417 
Signed-off-by: YangKeao <[email protected]>
@YangKeao YangKeao force-pushed the ttl-add-system-table branch from 9c0799e to e0fa417 Compare December 5, 2022 03:32
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 5, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Dec 5, 2022

/run-unit-test

bb7133
bb7133 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 5, 2022
@bb7133
Copy link
Member

bb7133 commented Dec 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e0fa417

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Dec 5, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Dec 5, 2022

Oops. Forget to unhold the PR 🤦

@YangKeao
Copy link
Member Author

YangKeao commented Dec 5, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit a7c4c71 into pingcap:master Dec 5, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 5, 2022
Merged
4 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39619.

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 26 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 17 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 10 min Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 22 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 0 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 31 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 5, 2022
Merged
4 tasks
YangKeao added a commit to ti-chi-bot/tidb that referenced this pull request Dec 16, 2022
This is an automated cherry-pick of pingcap#39315
998315b 
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: YangKeao <[email protected]>
ti-chi-bot added a commit that referenced this pull request Dec 19, 2022
@ti-chi-bot
ttl: add system table for TTL status (#39315) (#39619)
9ba51af 
close #39272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add system table mysql.tidb_ttl_table_status
6 participants
@YangKeao @ti-chi-bot @lcwangchao @bb7133 @sre-bot @hawkingrei