Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add syntax for ttl option in ddl #39277

Merged
merged 3 commits into from
Nov 22, 2022
Merged

parser: add syntax for ttl option in ddl #39277

merged 3 commits into from
Nov 22, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 21, 2022 •
edited
Loading

Signed-off-by: YangKeao [email protected]

What problem does this PR solve?

Issue Number: close #39268

Problem Summary:

In #39264 we drafted an RFC for row level ttl. This PR adds the parser support for it.

What is changed and how it works?

This PR modifies the yacc files to support setting TTL = column + INTERVAL expr TIME_UNIT and TTL_ENABLE = 'ON'/'OFF'.

Besides that, this PR also adds Visit function for TableOption, because an Expr field was added to the TableOption.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Add support for `TTL`, `TTL_ENABLE` and `NO_TTL` table options in create-table statement and alter-table statement.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2022
@YangKeao YangKeao marked this pull request as draft November 21, 2022 06:56
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2022
@YangKeao YangKeao force-pushed the ttl-create-table branch 2 times, most recently from 19eaee9 to 1eafc82 Compare November 21, 2022 07:16
@YangKeao YangKeao marked this pull request as ready for review November 21, 2022 07:19
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2022
@YangKeao YangKeao requested a review from lcwangchao November 21, 2022 08:00
@wuhuizuo
Copy link
Contributor

/run-all-tests

lcwangchao
lcwangchao reviewed Nov 21, 2022
View reviewed changes
parser/ast/ddl.go
@@ -1180,6 +1180,13 @@ func (n *CreateTableStmt) Accept(v Visitor) (Node, bool) {
}
n.Partition = node.(*PartitionOptions)
}
for i, option := range n.Options {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required by the PR? I think it is right to visit all the Options for CreateTableStmt.Accept. But I'm not sure why we did not do it before, maybe just because forgot it?

Copy link
Member Author

@YangKeao YangKeao Nov 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required by the PR?

Yes. The parser_test.go requires to visit all ExprNode to reset the offset. Without it, we cannot use the unit test utilities. This PR adds a ExprNode field to the option, so it's needed to visit the options.

lcwangchao
lcwangchao reviewed Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@lcwangchao lcwangchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2022
@hawkingrei
Copy link
Member

/run-all-tests

@YangKeao YangKeao mentioned this pull request Nov 21, 2022
Merged
4 tasks
@YangKeao
Copy link
Member Author

/run-all-tests

@YangKeao
Copy link
Member Author

/run-unit-test

@YangKeao
Copy link
Member Author

/run-check_dev_2

@YangKeao
Copy link
Member Author

/run-unit-test

@YangKeao
Copy link
Member Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2793362

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@ti-chi-bot ti-chi-bot merged commit 2255898 into pingcap:master Nov 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 2, success 37, total 39 21 min New failing
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 4 min 31 sec New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 0 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 50 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@kennedy8312 kennedy8312 mentioned this pull request Apr 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parser support for TTL syntax
6 participants
@YangKeao @ti-chi-bot @wuhuizuo @hawkingrei @sre-bot @lcwangchao