Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: Add index fast path to be a default add index path #39267

Merged
merged 14 commits into from
Nov 23, 2022
Merged

ddl: Add index fast path to be a default add index path #39267

merged 14 commits into from
Nov 23, 2022

Conversation

Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 commented Nov 21, 2022 •
edited by tangenta
Loading

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:
This PR will make tidb_ddl_enable_fast_reorg default and make Add index fast path to be default solution for add index.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Benjamin2037 Benjamin2037 requested a review from a team as a code owner November 21, 2022 03:25
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2022
@Benjamin2037
Copy link
Collaborator Author

/run_mysql-test

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run_test

@Benjamin2037
Copy link
Collaborator Author

/run_unit-test

@Benjamin2037
Copy link
Collaborator Author

/run-all-test

@Benjamin2037
Copy link
Collaborator Author

/run-build

@Benjamin2037
Copy link
Collaborator Author

/run-unit-test

@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

1 similar comment
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@wuhuizuo
Copy link
Contributor

/run-unit-test

1 similar comment
@Benjamin2037
Copy link
Collaborator Author

/run-unit-test

@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@Benjamin2037
Copy link
Collaborator Author

/run_mysql-test

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037 Benjamin2037 mentioned this pull request Nov 23, 2022
Closed
20 tasks
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

jackysp
jackysp approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

zimulala
zimulala reviewed Nov 23, 2022
View reviewed changes
ddl/cancel_test.go Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 commented Nov 23, 2022
View reviewed changes
ddl/db_change_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2022
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c9da8fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2022
@ti-chi-bot ti-chi-bot merged commit 9784615 into pingcap:master Nov 23, 2022
@Benjamin2037 Benjamin2037 deleted the add_index_GA branch November 23, 2022 07:50
@sre-bot
Copy link
Contributor

sre-bot commented Nov 23, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [5] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 25 min New failing
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 17 min New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 14 min New failing
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 6, success 22, total 28 11 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 4 min 37 sec New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 7 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 7 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 8 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@purelind purelind mentioned this pull request Nov 23, 2022
Merged
@lance6716 lance6716 mentioned this pull request Nov 23, 2022
Merged
@tangenta tangenta mentioned this pull request Nov 24, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benjamin2037 @ti-chi-bot @wuhuizuo @zimulala @sre-bot @jackysp