-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDL: add log when TiFlash replica available changed #39243
Conversation
Signed-off-by: hehechen <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Could you describe in the PR body or issue body about why do we need this change? |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@CalvinNeo: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/assign @breezewish |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7328b3d
|
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
Signed-off-by: hehechen [email protected]
What problem does this PR solve?
Issue Number: close #39242
Problem Summary:
Currently partition tables only print log about
partitionID
but nottableID
when they becomeavailable
, it's inconvenient to find out if the partition table available when address bugs.What is changed and how it works?
Add log when TiFlash replica available changed
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.