Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: release memory when adding index on partitions finish #39190

Merged
merged 4 commits into from
Nov 17, 2022
Merged

ddl: release memory when adding index on partitions finish #39190

merged 4 commits into from
Nov 17, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39189

Problem Summary:

The tables with a lot of partitions cannot use the ingest method to create index. This is because

  1. newAddIndexWorker() increases the writer count and never decrease it until the engine is unregistered.
  2. The backend and engine is reused for different partitions.
  3. An error is reported when writer count becomes too large, and TiDB tries to fallback to the "txn-merge" method.

What is changed and how it works?

Reset the writer counter and memory usage when a partition is done.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2022
Benjamin2037
Benjamin2037 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Benjamin2037 Benjamin2037 self-requested a review November 16, 2022 11:55
Benjamin2037
Benjamin2037 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@tangenta: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 31627fe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2022
@ti-chi-bot ti-chi-bot merged commit ad06a1f into pingcap:master Nov 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 17, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 43 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 18 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 41 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 0 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 50 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

tangenta added a commit to tangenta/tidb that referenced this pull request Nov 21, 2022
@tangenta
ddl: release memory when adding index on partitions finish (pingcap#3…
6db7386 
…9190)

close pingcap#39189
@tangenta tangenta mentioned this pull request Nov 21, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Nov 21, 2022
@tangenta
ddl: add index using ingest 640 hotfix (#39274)
5afdf35 
ref #39190, ref #39239
@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 6, success 0, total 6 12 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 all 1 tests passed 3 min 41 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ 35 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 0 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 6 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 6 days 19 hr Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 0 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
affects-6.3 affects-6.4 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add index with ingest method does not work well on partition tables
6 participants
@tangenta @ti-chi-bot @hawkingrei @sre-bot @Benjamin2037 @xiongjiwei