Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser, executor: implement plan replayer capture statement #39181

Merged
merged 12 commits into from
Nov 17, 2022
Merged

parser, executor: implement plan replayer capture statement #39181

merged 12 commits into from
Nov 17, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Nov 16, 2022

What problem does this PR solve?

Issue Number: ref #38779

Problem Summary:

What is changed and how it works?

implement plan replayer capture statement

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Yisaer Yisaer requested review from hawkingrei and qw4990 November 16, 2022 06:08
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2022
qw4990
qw4990 reviewed Nov 16, 2022
View reviewed changes
executor/plan_replayer.go Outdated Show resolved Hide resolved
@Yisaer
address the comment
829aaa4 
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from a team as a code owner November 17, 2022 05:25
@Yisaer Yisaer requested a review from qw4990 November 17, 2022 05:25
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2022
@Yisaer
address the comment
74ca0c2 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74ca0c2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2022
@hawkingrei
Copy link
Member

/run-all-tests

@hawkingrei
Copy link
Member

/run-all-tests

@hawkingrei
Copy link
Member

/run-all-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 17, 2022

/run-unit-test

@Yisaer
address the comment
efbf548 
Signed-off-by: yisaer <[email protected]>
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 17, 2022

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: efbf548

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2022
@ti-chi-bot ti-chi-bot merged commit 9c48480 into pingcap:master Nov 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 17, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 22 min New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 4 min 33 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 5 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 13 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 4 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @ti-chi-bot @hawkingrei @sre-bot @qw4990