-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile: use rockylinux #39175
dockerfile: use rockylinux #39175
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one thing, releasing is not using this file. I don't think changing this makes any difference other than using glibc.
Signed-off-by: Weizhen Wang <[email protected]>
I agree with you. But it might be some compliance issue. |
Clearly, that is not a problem. Because I am using musl. If there is any problem, I will fix it. 😄 And, go does not have much left problems on musl libc. Talking about containers for go programs, alpine is the best choice. /merge |
This pull request has been accepted and is ready to merge. Commit hash: 4d04a0f
|
TiDB MergeCI notify🔴 Bad News! [3] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #38933
Problem Summary:
What is changed and how it works?
Check List
Tests
make docker
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.