Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: change the mpp response chan size to 0 #39151

Merged
merged 4 commits into from
Nov 21, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix goleak in test
wshwsh12 committed Nov 21, 2022
commit 4740664097f92133050184d2e77d0a9c88dd0249
6 changes: 4 additions & 2 deletions telemetry/data_window_test.go
Original file line number Diff line number Diff line change
@@ -94,9 +94,11 @@ func TestTiflashUsage(t *testing.T) {
require.Equal(t, telemetry.CurrentTiflashTableScanCount.String(), "0")
require.Equal(t, telemetry.CurrentTiflashTableScanWithFastScanCount.String(), "0")

tk.MustExec("set session tidb_isolation_read_engines='tiflash';select count(*) from t")
tk.MustExec("set session tidb_isolation_read_engines='tiflash';")
tk.MustQuery(`select count(*) from t`)
tk.MustExec(`set @@session.tiflash_fastscan=ON`)
tk.MustExec(`set session tidb_isolation_read_engines="tiflash";select count(*) from test.t`)
tk.MustExec(`set session tidb_isolation_read_engines="tiflash";`)
tk.MustQuery(`select count(*) from test.t`)

tk.Session().Close()
require.Equal(t, telemetry.CurrentTiflashTableScanCount.String(), "2")