ddl: modify default unique index name #39145

wxbty · 2022-11-15T02:57:10Z

What problem does this PR solve?

Make the default name of the unique index consistent with mysql

Issue Number: close #39080

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test TestIssue39080
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: x-shadow-man <[email protected]>

ti-chi-bot · 2022-11-15T02:57:12Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lance6716
xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

wxbty · 2022-11-15T03:00:18Z

/cc @xhebox @wjhuang2016

lance6716 · 2022-11-15T03:38:21Z

run test [alter_table_PK] err: sql:SHOW INDEX FROM t1;: failed to run query
"SHOW INDEX FROM t1;"
 around line 52,
we need(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

but got(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	Host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

one of our internal test is failed, PTAL @xhebox

xhebox · 2022-11-15T05:18:32Z

run test [alter_table_PK] err: sql:SHOW INDEX FROM t1;: failed to run query
"SHOW INDEX FROM t1;"
 around line 52,
we need(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

but got(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	Host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

one of our internal test is failed, PTAL @xhebox

Okay... Let me fix it.

xhebox · 2022-11-15T05:58:28Z