domain: support dump plan replayer capture task during query #39125
Conversation
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
executor/compiler.go
Outdated
| enabledPlanReplayerCapture := variable.EnablePlanReplayerCapture.Load() | ||
| failpoint.Inject("enablePlanReplayerCapture", func(val failpoint.Value) { | ||
| if val.(bool) { | ||
| enabledPlanReplayerCapture = true | ||
| } | ||
| }) | ||
| if enabledPlanReplayerCapture { | ||
| checkPlanReplayerCaptureTask(c.Ctx, stmtNode) | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we move this operation into planner/optimize.go:optimize()? Putting it into the planner package seems more reasonable.
There was a problem hiding this comment.
To build a PlanReplayerDump task with less consuming in query process, we introducing the function inexector, thus we can't move it into planner which would cause cycle import.
Signed-off-by: yisaer <[email protected]>
Yisaer
force-pushed
the
support_capture_task
branch
from
cfb154d to
8f0009e
Compare
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Yisaer
force-pushed
the
support_capture_task
branch
from
ff9a23d to
dcf128d
Compare
Signed-off-by: yisaer <[email protected]>
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f75da42
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #38779
Problem Summary:
What is changed and how it works?
support dump plan replayer capture task during query
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.