Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gogctuner: fix unstable test in the TestTuner #39101

Merged
merged 8 commits into from
Nov 14, 2022
Merged

gogctuner: fix unstable test in the TestTuner #39101

merged 8 commits into from
Nov 14, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38467

Problem Summary:

What is changed and how it works?

Now the default min value of GOGC is 100 for gogc tuner. so This range in test is too small to run.

the origin threshold is so small for the test case to be disturbed by the memory of the test framework.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Run the test 100 times
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 13, 2022
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-6.4 and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 13, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2022
@hawkingrei hawkingrei requested a review from lance6716 November 13, 2022 13:58
lance6716
lance6716 reviewed Nov 13, 2022
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the default min value of GOGC is 100 for gogc tuner

Why we do this? I'm afraid it will increase the possibility of OOM.

util/gctuner/tuner_test.go Outdated
require.GreaterOrEqual(t, tn.getGCPercent(), uint32(50))
require.LessOrEqual(t, tn.getGCPercent(), uint32(100))
require.GreaterOrEqual(t, tn.getGCPercent(), MinGCPercent)
require.LessOrEqual(t, tn.getGCPercent(), uint32(200))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not change? the active heap can be equal or larger than threshold/2, so we should expect the percentage equal or less than 100%.

Also, this test have repeated many hardcode values.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the origin threshold is so small for the test case to be disturbed by the memory of the test framework.

@hawkingrei
Copy link
Member Author

hawkingrei commented Nov 13, 2022 •
edited
Loading

Now the default min value of GOGC is 100 for gogc tuner

Why we do this? I'm afraid it will increase the possibility of OOM.

At the earliest, the default value of gogctuner is less than 100. the main reason is the global memory limiter needs to use GOGC to judge the time of forcely garbage collection. so we need to change our strategy. GOGC tuner now has a max memory threshold. if memory is over it, gogc tuner will stop working. this threshold is always less than the threshold of global memory limiter. So that it can avoid the OOM

@hawkingrei
update
6716953 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2022
@hawkingrei
update
cf3183e 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from lance6716 November 14, 2022 01:09
@hawkingrei
update
7051f35 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 14, 2022
@xhebox
Copy link
Contributor

xhebox commented Nov 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7051f35

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@ti-chi-bot ti-chi-bot merged commit 61b02ec into pingcap:master Nov 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 14, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 43 min New failing
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 23 min New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 10 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 44 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 16 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 44 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 4 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@hawkingrei hawkingrei deleted the fix_unstable_Test branch November 14, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@xhebox xhebox xhebox approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable test: TestTuner
6 participants
@hawkingrei @ti-chi-bot @xhebox @sre-bot @lance6716 @Yisaer