Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stmtctx: remove the empty values in StatementContext.Tables #39086

Merged
merged 3 commits into from
Nov 11, 2022
Merged

stmtctx: remove the empty values in StatementContext.Tables #39086

merged 3 commits into from
Nov 11, 2022

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #38493

Problem Summary:

The StatementContext.Tables records the all tables/databases we are accessing in the statement. But some times it have some empty value (db == "" and table == "").

The reason is that the tables are from planBuilder.visitInfos , but it not only contains database/tables, it also contains some dynamic privilege visitInfos, so we should filter those visitInfos out.

What is changed and how it works?

filter out the visitInfos with dynamic privilege out.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2022
@lcwangchao lcwangchao mentioned this pull request Nov 11, 2022
Open
14 tasks
@lcwangchao lcwangchao changed the title stmtctx: make the StatementContext.Tables more accurate stmtctx: remove the empty values in StatementContext.Tables Nov 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
bb7133
bb7133 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2022
@bb7133
Copy link
Member

bb7133 commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a0fc707

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@lcwangchao
Copy link
Collaborator Author

/merge

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 483d2bc into pingcap:master Nov 11, 2022
@lcwangchao lcwangchao deleted the stmtctx_tables branch November 11, 2022 09:44
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [3] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 43 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 10 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 19 min Fixed
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 17 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 12 min Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 41 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 50 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new framework to extend tidb's function outside the repo
5 participants
@lcwangchao @ti-chi-bot @bb7133 @sre-bot @xhebox