ddl: refine logic of OwnerCheckAllVersions

[wjhuang2016]

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

cluster_info may return invalid TiDB info, in OwnerCheckAllVersions, it doesn't need to check the invalid TiDB info.
If two instances have the same address and port, we know that the one started earlier is invalid.

mysql> select * from information_schema.cluster_info;
+------+---------------------+---------------------+-------------+------------------------------------------+---------------------------+---------------+-----------+
| TYPE | INSTANCE            | STATUS_ADDRESS      | VERSION     | GIT_HASH                                 | START_TIME                | UPTIME        | SERVER_ID |
+------+---------------------+---------------------+-------------+------------------------------------------+---------------------------+---------------+-----------+
| tidb | 192.168.0.102:50002 | 192.168.0.102:28002 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:04+08:00 | 45.575834s    |    724453 |
| tidb | 192.168.0.102:50003 | 192.168.0.102:28003 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:18+08:00 | 31.575837s    |   3596895 |
| tidb | 192.168.0.102:50001 | 192.168.0.102:28001 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:43+08:00 | 6.575845s     |   2636387 |
| tidb | :4000               | :10080              | None        | None                                     | 2022-11-10T17:01:02+08:00 | 47.575848s    |   3272260 |
| tidb | 192.168.0.102:50003 | 192.168.0.102:28003 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:05+08:00 | 44.575849s    |   1515429 |
| tidb | 127.0.0.1:4001      | 127.0.0.1:10081     | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T16:34:21+08:00 | 27m28.57585s  |     20915 |
| tidb | 127.0.0.1:4000      | 127.0.0.1:10080     | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T16:34:21+08:00 | 27m28.57585s  |    116956 |
| tidb | 192.168.0.102:50001 | 192.168.0.102:28001 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:02+08:00 | 47.575851s    |    110384 |
| tidb | 192.168.0.102:50001 | 192.168.0.102:28001 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:30+08:00 | 19.575852s    |   1788048 |
| tidb | 127.0.0.1:4002      | 127.0.0.1:10082     | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T16:34:20+08:00 | 27m29.575853s |   2794409 |
| pd   | 127.0.0.1:2379      | 127.0.0.1:2379      | 6.5.0-alpha | 91f16642cfa3dc53da5aafa481afa63159224aaf | 2022-11-10T16:33:59+08:00 | 27m50.575855s |         0 |
| tikv | 127.0.0.1:20161     | 127.0.0.1:20181     | 6.5.0-alpha | f2e89a4e80e2b99d7ac2abe74d38d4f6eac9ceb6 | 2022-11-10T16:34:03+08:00 | 27m46.575858s |         0 |
| tikv | 127.0.0.1:20162     | 127.0.0.1:20182     | 6.5.0-alpha | f2e89a4e80e2b99d7ac2abe74d38d4f6eac9ceb6 | 2022-11-10T16:34:03+08:00 | 27m46.575859s |         0 |
| tikv | 127.0.0.1:20160     | 127.0.0.1:20180     | 6.5.0-alpha | f2e89a4e80e2b99d7ac2abe74d38d4f6eac9ceb6 | 2022-11-10T16:34:03+08:00 | 27m46.57586s  |         0 |
+------+---------------------+---------------------+-------------+------------------------------------------+---------------------------+---------------+-----------+

What is changed and how it works?

Don't check the invalid TiDB in OwnerCheckAllVersions

Check List

Tests

• Unit test
• Integration test
  Pass the intergration_ddl test.
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lcwangchao
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 7407a13

[sre-bot]

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test	🟥 failed 1, success 16, total 17	13 min	New failing
idc-jenkins-ci/integration-cdc-test	🔴 failed 1, success 38, total 39	20 min	Existing failure
idc-jenkins-ci-tidb/mybatis-test	🔴 failed 1, success 0, total 1	11 min	Existing failure
idc-jenkins-ci-tidb/integration-ddl-test	🔴 failed 2, success 4, total 6	5 min 3 sec	Existing failure
idc-jenkins-ci-tidb/common-test	🟢 all 11 tests passed	17 min	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	7 min 19 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	6 min 23 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	5 min 10 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	2 min 59 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed