Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: support plan_replayer_task system table #39019

Merged
merged 16 commits into from
Nov 11, 2022
Merged

domain: support plan_replayer_task system table #39019

merged 16 commits into from
Nov 11, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Nov 9, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38779

Problem Summary:

What is changed and how it works?

support plan_replayer_task system table in order to register pattern for plan replayer capture

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Yisaer added 8 commits November 1, 2022 12:48
@Yisaer
refactor
acdd6d7 
Signed-off-by: yisaer <[email protected]>
@Yisaer
fix lint
74026c4 
Signed-off-by: yisaer <[email protected]>
@Yisaer
support
77d9af5 
Signed-off-by: yisaer <[email protected]>
@Yisaer
Merge remote-tracking branch 'upstream/master' into support_replayer_…
c60cfbe 
…capture
@Yisaer
revise
9d1bc4a 
Signed-off-by: yisaer <[email protected]>
@Yisaer
add test
2a3c459 
Signed-off-by: yisaer <[email protected]>
@Yisaer
add test
386f9ab 
Signed-off-by: yisaer <[email protected]>
@Yisaer
support replayer task
0e86389 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 9, 2022
@Yisaer Yisaer force-pushed the support_replayer_task branch from 826d8d8 to c445b51 Compare November 10, 2022 04:12
@Yisaer Yisaer marked this pull request as ready for review November 10, 2022 04:12
@Yisaer Yisaer requested a review from a team as a code owner November 10, 2022 04:12
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2022
@Yisaer
fix test
21f08b5 
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested review from qw4990 and hawkingrei November 10, 2022 04:48
hawkingrei
hawkingrei reviewed Nov 10, 2022
View reviewed changes
session/bootstrap.go Outdated Show resolved Hide resolved
@Yisaer
address the comment
654d2ce 
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from hawkingrei November 11, 2022 06:06
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
@Yisaer Yisaer force-pushed the support_replayer_task branch from fde96f3 to 8727ddf Compare November 11, 2022 06:43
@Yisaer
address the comment
959f202 
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer force-pushed the support_replayer_task branch from b0f5054 to 959f202 Compare November 11, 2022 06:44
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9f0a8d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@ti-chi-bot ti-chi-bot merged commit ddb4355 into pingcap:master Nov 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 6 min 14 sec New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 10 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 21 min Fixed
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 19 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 7 min 21 sec Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 36 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 36 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 46 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support record query replan replayer info if it matches digest.
5 participants
@Yisaer @ti-chi-bot @sre-bot @hawkingrei @qw4990