-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoid_service,server: handle TLS config of the etcd client #38975
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
1 similar comment
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ea830b7
|
/run-unit-test |
In response to a cherrypick label: new pull request created: #38985. |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close ##38977
Problem Summary:
What is changed and how it works?
The etcd client doesn't config the TLS, so when tidb TLS is enabled, the autoid service can't connect to the pd (etcd) to elect leader.
It will retry elect leader forever and block other things.
Check List
Tests
Found by existing tests that enable TLS
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.