Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: truncate metadata streamingly (#38870) #38972

Merged
merged 9 commits into from
Nov 9, 2022
Merged

log-backup: truncate metadata streamingly (#38870) #38972

merged 9 commits into from
Nov 9, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #38870

Signed-off-by: Leavrth [email protected]

What problem does this PR solve?

Issue Number: close #38869 #38939 #38940

Problem Summary:
truncate metadata streamingly to avoid oom

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Nov 8, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.4 labels Nov 8, 2022
joccau
joccau approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2022
@joccau
Copy link
Member

joccau commented Nov 8, 2022

/run-check_dev_2
/run-mysql-test

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 8, 2022
@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/merge

1 similar comment
@3pointer
Copy link
Contributor

3pointer commented Nov 9, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 911a074

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2022
@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-mysql-test

@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-unit-test

@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-mysql-test

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-mysql-test

@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-mysql-test

@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-unit-test

@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-mysql-test

2 similar comments
@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/run-mysql-test

@hawkingrei
Copy link
Member

/run-mysql-test

@Leavrth
Copy link
Contributor

Leavrth commented Nov 9, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit d662237 into pingcap:release-6.4 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees

@Leavrth Leavrth

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @joccau @Leavrth @3pointer @hawkingrei @sre-bot