auto_inc,constraint: Ignore check constraint for auto-increment check #38966
Conversation
Signed-off-by: YangKeao <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
YangKeao
changed the title
| @@ -675,6 +675,10 @@ func checkAutoIncrementOp(colDef *ast.ColumnDef, index int) (bool, error) { | |||
|
|
|||
| func isConstraintKeyTp(constraints []*ast.Constraint, colDef *ast.ColumnDef) bool { | |||
There was a problem hiding this comment.
BTW, can we change the name of this function(or some comments)? I am worrying that somebody will use this function for non-auto-incr columns.
There was a problem hiding this comment.
It returns whether the column is a constraint key.
I think it's fine to use it for other purpose, at least the change in this PR doesn't break it, because the CHECK constraint cannot be regarded as a key (and is not supported by TiDB, as described in the document) 🤔 .
| tk.MustExec(`CREATE TABLE t ( | ||
| id INTEGER NOT NULL AUTO_INCREMENT, | ||
| CHECK (id IN (0, 1)), | ||
| KEY idx_autoinc_id (id) |
There was a problem hiding this comment.
Yes. The AUTO_INCREMENT column has to be defines as a key (any kind is fine).
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 802e0cc
|
ti-chi-bot
added
the
status/can-merge
|
In response to a cherrypick label: new pull request created: #39043. |
|
In response to a cherrypick label: new pull request created: #39044. |
|
In response to a cherrypick label: new pull request created: #39045. |
|
In response to a cherrypick label: new pull request created: #39046. |
|
In response to a cherrypick label: new pull request created: #39047. |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
Signed-off-by: YangKeao <[email protected]>
Signed-off-by: YangKeao <[email protected]>
Signed-off-by: YangKeao <[email protected]>
Signed-off-by: YangKeao <[email protected]>
Signed-off-by: YangKeao <[email protected]>
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #38894
Problem Summary:
While checking the auto-increment column is a key and iterating through the constraints, the check constraint doesn't have any key and return an error.
What is changed and how it works?
If the constraint is a
check, just ignore it in this function.Check List
Tests
Release note