Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: make min start ts reporter aware of internal session from get_lock() (#38790) #38827

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #38790

What problem does this PR solve?

Issue Number: close #38706

Problem Summary:

Before this PR, the pessimistic transaction started by get_lock() can only live several minutes:

[WARN] [2pc.go:1118] ["stop TxnHeartBeat"] [error="txn 437065830059212803 heartbeat fail, primary key = 7480000000000000435f698000000000000001016100000000000000f8, err = txn 437065830059212803 not found"]

TiDB needs to report the minimal start ts to PD regularly, in order to advance the GC savepoint. However, the reporter is not aware of the pessimistic transaction started by get_lock(). When the GC worker cleans the lock record, the above error is reported.

What is changed and how it works?

This PR makes the min start ts reporter aware of get_lock() transaction.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
select get_lock('hello', 0);
...
[INFO] [2pc.go:1107] ["send TxnHeartBeat"] [startTS=437068143044853763] [newTTL=31000]
...
[INFO] [2pc.go:1107] ["send TxnHeartBeat"] [startTS=437068143044853763] [newTTL=2651034]

The lock could be hold for more than 40 mins.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix an issue that `get_lock()` cannot hold for more than 10 minutes.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.3 labels Nov 2, 2022
@tangenta
Copy link
Contributor

tangenta commented Nov 2, 2022

6.3.x will not be released.

@tangenta tangenta closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants